AI-generated extensions to gr_ore_poly: action on the base ring, conversions#2769
Draft
mezzarobba wants to merge 7 commits into
Draft
AI-generated extensions to gr_ore_poly: action on the base ring, conversions#2769mezzarobba wants to merge 7 commits into
mezzarobba wants to merge 7 commits into
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit contains both AI-generated code and human changes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The just-added implementation was incorrect for Ore polynomial rings of the same algebra type but with unequal parameters. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
albinahlback
reviewed
Jul 6, 2026
Comment on lines
+1
to
+3
| /* | ||
| This file is part of FLINT. | ||
|
|
Collaborator
There was a problem hiding this comment.
Surely this should be attributed to you? (At least my view is that the copyright also indicates who is "responsible" for the code.)
Contributor
Author
|
On Monday, 6 July 2026 Albin Ahlbäck wrote:
Surely this should be attributed to you? (At least my view is that
the copyright also indicates who is "responsible" for the code.)
I do take responsability for the code, but I don't claim to have any
copyrightable contribution, so it would feel strange to add a copyright
line with my name (I'm not opposed to doing it if that's the rule).
…--
Marc
|
Collaborator
|
The files are still copyrighted, so that would go to FLINT as a project
instead? (Sorry for the stupid question, I'm not superfamiliar with
exactly how copyright work. I guess the LLM is heavily inspired from the
project, so that would make sense)
…On Mon, Jul 6, 2026, 19:16 Marc Mezzarobba ***@***.***> wrote:
*mezzarobba* left a comment (flintlib/flint#2769)
<#2769 (comment)>
On Monday, 6 July 2026 Albin Ahlbäck wrote:
> Surely this should be attributed to you? (At least my view is that
> the copyright also indicates who is "responsible" for the code.)
I do take responsability for the code, but I don't claim to have any
copyrightable contribution, so it would feel strange to add a copyright
line with my name (I'm not opposed to doing it if that's the rule).
--
Marc
—
Reply to this email directly, view it on GitHub
<#2769?email_source=notifications&email_token=AOGBZ5YT75UBYXDTR74VRHT5DPNFHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBZGU3DIMBQGAZ2M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4895640003>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AOGBZ52DRSIJWYMGRO4E2MD5DPNFHAVCNFSNUABDKJSXA33TNF2G64TZHMZTAOBWGM3DMO2JONZXKZJ3GQ4DEMJRHA3DONBTUF3AE>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AOGBZ52X4LLZQLXZ7O3GMKT5DPNFHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBZGU3DIMBQGAZ2M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/AOGBZ53445O7I6ZQY3QCX235DPNFHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBZGU3DIMBQGAZ2M4TFMFZW63VHMNXW23LFNZ2KKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you commented.Message ID:
***@***.***>
|
Collaborator
|
No strong opinion. When you contribute to FLINT, you remain the copyright holder but agree to license your work under the LGPL. "Transfer the copyright to FLINT as a project" is meaningless since FLINT isn't a legal entity. (Some other projects have such a setup though.) The boilerplate at the top of each file just serves to inform the user that the LGPL applies. It doesn't really matter legally (as I far as I understand) whether it actually names the year and author, and if it names the author but the contents aren't actually copyrightable then the copyright notice is just vacuous (and the license still applies, vacuously). On the other hand, it's nice for documentation purposes to have the original year and author up front... |
Collaborator
|
The code looks fine, by the way. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My turn to play with LLMs
;-)This PR adds
gr_ore_polyfunctions for applying an operator to an element of its base ring and for converting between representations of a same operator in different Ore polynomial rings of the same family (differential or difference) as well as between differential and difference operators.The code is almost entirely LLM-generated, though with multiple rounds of review and revisions. (The changes I made myself appear as separate commits, intermediate LLM-generated versions do not.)