ProfilingSettings takes a nonnegative_int and a positive_int#1657
Open
elliottslaughter wants to merge 2 commits into
Open
ProfilingSettings takes a nonnegative_int and a positive_int#1657elliottslaughter wants to merge 2 commits into
elliottslaughter wants to merge 2 commits into
Conversation
Collaborator
Author
|
So it occurs to me, re-reading this code, that I'm not sure this is the right fix. The original code clearly is intended to permit a no-op when @lockshaw I guess up to you whether you think this is a useful change or not. The other option is to just fix the call sites (in which case new users might continue to make the same mistake, setting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This splits out the first part of #1641 so that we can start to merge pieces without taking the whole monolithic ~4,000 line diff all at once.
This adds constraints on
ProfilingSettingsby typing the fields more accurately tononnegative_intandpositive_intrespectively. Previously we had a lot of tests that simply weren't running due to passing zero for both parameters.The impact of this change is that tests may start running that were previously effectively being no-oped out. Thus, if you merge this before #1640 we may see failures in that PR, and vice versa if you merge #1640 first then you may discover that it actually broke something silently (because some tests may not actually be exercised right now).
This passes CPU and GPU tests on master as long as you merge #1656 first (an otherwise unrelated change).
This change is