Skip to content

fix: close dashboard context panels on route exit - #332

Open
KenkoGeek wants to merge 1 commit into
fleetbase:mainfrom
KenkoGeek:fix/458-close-place-panel-on-navigation
Open

KenkoGeek wants to merge 1 commit into
fleetbase:mainfrom
KenkoGeek:fix/458-close-place-panel-on-navigation

Conversation

@KenkoGeek

Copy link
Copy Markdown

Summary

Close any open resource context panels when the FleetOps dashboard route is exited so a place details panel does not remain visible after navigating to Places.

The cleanup is attached to Ember's Route#deactivate hook, which only runs when the route is fully exited, rather than reacting to every route change.

Fixes fleetbase/fleetbase#458

Testing

  • Added a regression test for operations/orders/index route teardown
  • pnpm lint
  • pnpm build
  • pnpm exec ember test --test-port 0 --module "Unit | Route | operations/orders/index" --reporter tap

References

@roncodes

Copy link
Copy Markdown
Member

This works but I'm not sure this is the appropriate fix to the issue, I will need to investigate further on the correct approach. This seems to work for one section of the module, and the implementation is catch-all for the operations route. It might need a proper fix from the context-panel service itself. Will update after digging a bit deeper.

@codecov

codecov Bot commented Sep 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.99%. Comparing base (7f581a3) to head (394fc6a).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #332   +/-   ##
=========================================
  Coverage     99.99%   99.99%           
  Complexity    11936    11936           
=========================================
  Files           583      583           
  Lines         44892    44892           
=========================================
  Hits          44891    44891           
  Misses            1        1           
Flag Coverage Δ
backend 99.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FleetOps: Place sidebar doesn't close when clicking Places tab and allows multiple overlapping sidebars

2 participants