Conversation
Member
|
This works but I'm not sure this is the appropriate fix to the issue, I will need to investigate further on the correct approach. This seems to work for one section of the module, and the implementation is catch-all for the operations route. It might need a proper fix from the context-panel service itself. Will update after digging a bit deeper. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
=========================================
Coverage 99.99% 99.99%
Complexity 11936 11936
=========================================
Files 583 583
Lines 44892 44892
=========================================
Hits 44891 44891
Misses 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close any open resource context panels when the FleetOps dashboard route is exited so a place details panel does not remain visible after navigating to Places.
The cleanup is attached to Ember's
Route#deactivatehook, which only runs when the route is fully exited, rather than reacting to every route change.Fixes fleetbase/fleetbase#458
Testing
operations/orders/indexroute teardownpnpm lintpnpm buildpnpm exec ember test --test-port 0 --module "Unit | Route | operations/orders/index" --reporter tapReferences
resource-context-panel.closeAll()API from@fleetbase/ember-ui