fix(openapi): alert pipeline if and alert_inhibit.source_filters are AND-lists - #307
Merged
Conversation
…are AND-lists The server models both fields as a single AND group — a flat list of conditions — but the spec pointed them at OrFilterGroup, whose shape is an OR-of-AND nesting. Generated clients therefore fail to decode any alert pipeline that carries an `if` condition: json: cannot unmarshal object into Go struct field AlertPipeline.rules.if of type []FilterCondition Point both at a flat array of FilterCondition, matching how EnrichRule.if and RouteCase.if already describe the same server type. OrFilterGroup itself is unchanged: the silence / inhibit / drop / escalation rules that reference it through FilterGroup really are OR-of-AND, and those decode correctly today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server models both fields as a single AND group — a flat list of conditions — but the spec pointed them at
OrFilterGroup, whose shape is an OR-of-AND nesting. Generated clients therefore fail to decode any alert pipeline that carries anifcondition:Both fields now describe a flat array of
FilterCondition, matching howEnrichRule.ifandRouteCase.ifalready describe the same server-side type.OrFilterGroupitself is unchanged: the silence / inhibit / drop / escalation rules that reference it throughFilterGroupreally are OR-of-AND, and they decode correctly today.Files:
on-call.openapi.{en,zh}.jsonand the aggregatedopenapi.{en,zh}.json, two properties each.