chore(release): 0.1.3 - #13
Merged
Merged
Conversation
Corrects the version the SDK reports. 0.1.2 bumped the packages but not the native SdkVersion files, so it ships `_dd.sdk_version: 0.1.1` while npm serves 0.1.2, and support reads the wrong version off an event. npm versions are immutable, so the fix is the next one. No functional change since 0.1.2: the custom endpoint fix it carries is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
0.1.2 bumped the packages but not the native
SdkVersion.swift/SdkVersion.kt, which feed_dd.sdk_version. The published 0.1.2 therefore reports0.1.1in its events while npm serves0.1.2, so support reads the wrong version off an event. npm versions are immutable, so the correction is the next release.No functional change since 0.1.2 — the custom endpoint fix it carries is unchanged.
Bump
All thirteen places the version is written:
lerna.json, everypackages/*/package.json, the generatedpackages/core/src/version.ts, and both nativeSdkVersionfiles.NATIVE_SDK_VERSIONS.mdgains a 0.1.3 row; the native pins are unchanged (Android0.5.0, iOS~> 0.5).example/ios/Podfile.lockis left alone. It still records0.1.0and was not touched by the 0.1.1 or 0.1.2 bumps either — it locks the example app, not a published artifact.Checks
That check is exactly what 0.1.2 would have failed.
yarn test: 876 passed, 1 skipped, 0 failed.Releasing
After this merges, tag the merge commit
v0.1.3and push it — that is what publishes now.