ci: run the test suite on every pull request - #12
Merged
Conversation
The suite only ran on a developer's machine. CI first touched a build in the publish workflow, which is too late to learn anything: by then it is publishing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This repo had no CI that ran the tests. The three workflows were CodeQL, publish and stale, so the first time CI touched a build was the publish workflow — by which point it is publishing, which is too late to learn anything from.
What
A
CIworkflow that installs and runsyarn teston every pull request, and on pushes topublish. Same pinned actions and Node version as the publish workflow, and the same plainyarninstall, so a green run here means the same tree the release builds from.Only the test suite.
yarn lintcurrently reports 222 pre-existing problems across the repo, so wiring it in now would make CI red on arrival and teach everyone to ignore it; that is worth fixing separately.Checks
yarn testlocally on this branch: 876 passed, 1 skipped, 0 failed, 129 snapshots.This PR is itself the first run of the workflow.