Skip to content

test: disable the string-building micro-benchmark #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fiona2016 merged 1 commit into from
Aug 24, 2026
Merged

test: disable the string-building micro-benchmark #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .../src/test/kotlin/com/datadog/android/utils/JointToStringVsStringBuilderPerformanceTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import com.datadog.android.internal.utils.appendIfNotEmpty
import fr.xgouchet.elmyr.Forge
import fr.xgouchet.elmyr.junit5.ForgeExtension
import org.assertj.core.api.Assertions.assertThat
import org.junit.jupiter.api.Disabled
import org.junit.jupiter.api.Test
import org.junit.jupiter.api.extension.ExtendWith
import org.junit.jupiter.api.extension.Extensions
Expand All @@ -20,6 +21,11 @@ import kotlin.system.measureNanoTime
@Extensions(
ExtendWith(ForgeExtension::class)
)
@Disabled(
"Wall-clock micro-benchmark rather than a correctness test: it compares two string-building " +
"approaches by measured time, so it flips on a shared CI runner and fails a release that is " +
"otherwise sound. Run it locally when the performance claim needs revisiting."
)
internal class JointToStringVsStringBuilderPerformanceTest {

@Test
Expand Down
Loading