Skip to content

[1.x] fix: allow boolean settings with truthy defaults to be disabled#4783

Open
huoxin233 wants to merge 1 commit into
flarum:1.xfrom
huoxin233:huoxin/1.x-fix-boolean-setting-fallback
Open

[1.x] fix: allow boolean settings with truthy defaults to be disabled#4783
huoxin233 wants to merge 1 commit into
flarum:1.xfrom
huoxin233:huoxin/1.x-fix-boolean-setting-fallback

Conversation

@huoxin233

Copy link
Copy Markdown
Contributor

Fixes #4781

Changes proposed in this pull request:

Backport fix #4782 to 1.x

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@huoxin233 huoxin233 requested a review from a team as a code owner June 26, 2026 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant