Add role attribute to PostStream item for accessibility#4780
Open
claudiushenrichs wants to merge 1 commit into
Open
Add role attribute to PostStream item for accessibility#4780claudiushenrichs wants to merge 1 commit into
claudiushenrichs wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
The PostStream document structure of a discussion is currently failing the "Elements with an ARIA [role] that require children to contain a specific [role] are missing some or all of those required children." accessibility test. The parent PostStream
This pull request adds role="article" attribute to the PostStream-item.
Reviewers should focus on:
A few lines further down in PostStream.js (around line 92) there is another reference to a container with classes "className="PostStream-item PostStream-afterFirstPost"" - I haven't figured out under which circumstances this container gets inserted, but it might also require the role=article. If anyone can shed some light on whether this is also a child within the PostStream feed parent container.
Screenshot

Necessity
Confirmed
composer test).