fix: Prevent drag updates from reaching removed components#3901
Merged
spydon merged 4 commits intoflame-engine:mainfrom Apr 14, 2026
Merged
Conversation
spydon
approved these changes
Apr 14, 2026
Member
spydon
left a comment
spydon
left a comment
There was a problem hiding this comment.
Lgtm, thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a crash caused by
MultiDragDispatchercontinuing to send drag updates to components that were removed during an active drag.Removed drag targets are now cancelled and cleaned up instead of receiving further updates. This also keeps drag state consistent for
DragCallbacks.Added regression tests for:
Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Fixes #3897