Rename VoIP status to callStatus - #584
Merged
Merged
Conversation
Magmusacy
force-pushed
the
rename/voip-call-status
branch
from
August 3, 2026 16:18
5278955 to
be6bc1b
Compare
MiloszFilimowski
approved these changes
Aug 4, 2026
MiloszFilimowski
left a comment
MiloszFilimowski
left a comment
Collaborator
There was a problem hiding this comment.
I hereby approve this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Renames the
statusfield returned fromuseVoIP()tocallStatus.Covers
VoIPContextValue,VoIPProvider, and thevoip-callexample app.Motivation and Context
statusis ambiguous next to the otherstatusvalues a Fishjam app alreadyhandles (
peerStatus, permission statuses);callStatusnames what it reports.Documentation impact
Types of changes
not work as expected)