Skip to content

fix: fetch submodule tags before checking webrtc release tag#553

Merged
czerwiukk merged 1 commit into
mainfrom
fix-mobile-submodule-script
Jun 24, 2026
Merged

fix: fetch submodule tags before checking webrtc release tag#553
czerwiukk merged 1 commit into
mainfrom
fix-mobile-submodule-script

Conversation

@czerwiukk

Copy link
Copy Markdown
Member

Motivation and Context

check:webrtc-published fails on CI but passes locally

  check-webrtc-published.mjs runs git -C packages/react-native-webrtc describe --exact-match --tags HEAD. That only works if the submodule's tags are present in .git.

  - Locally it passes because the dev has previously fetched the submodule's tags.
  - On GH Actions actions/checkout@v4 with submodules: recursive checks out the submodule at the pinned SHA but does not fetch its tags, so git describe finds nothing → "Submodule HEAD (6b994c0) is not at a tagged release".

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@czerwiukk czerwiukk self-assigned this Jun 24, 2026
@czerwiukk czerwiukk requested a review from Qizot June 24, 2026 07:36
@czerwiukk czerwiukk merged commit bcdae4b into main Jun 24, 2026
2 checks passed
@czerwiukk czerwiukk deleted the fix-mobile-submodule-script branch June 24, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants