Skip to content

Export encoding+reason in RemoteTrack#550

Merged
sgfn merged 2 commits into
mainfrom
sgfn/bwe
Jun 19, 2026
Merged

Export encoding+reason in RemoteTrack#550
sgfn merged 2 commits into
mainfrom
sgfn/bwe

Conversation

@sgfn

@sgfn sgfn commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Description

Add encoding and encodingReason fields to RemoteTrack

Motivation and Context

Display currently active layer
FCE-2939

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@sgfn sgfn requested a review from Karolk99 June 19, 2026 11:34

@Karolk99 Karolk99 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have e2e tests in this repo. I'm not sure if they test switching variants, but if they do, it's a good idea to check if the encoding value changes.

@sgfn

sgfn commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

We have e2e tests in this repo. I'm not sure if they test switching variants, but if they do, it's a good idea to check if the encoding value changes.

The react-client e2e tests don't cover encoding/variants at all. The webrtc-client e2e tests exercise setTargetTrackEncoding at the lower layer, but nothing touches usePeers. I'd leave it as-is

@sgfn sgfn merged commit c95c0c1 into main Jun 19, 2026
2 checks passed
@sgfn sgfn deleted the sgfn/bwe branch June 19, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants