Skip to content

Update manifest to reflect changes to fishjam-react-native-webrtc#547

Merged
Magmusacy merged 4 commits into
mainfrom
merge-fgs/FCE-2644
Jun 18, 2026
Merged

Update manifest to reflect changes to fishjam-react-native-webrtc#547
Magmusacy merged 4 commits into
mainfrom
merge-fgs/FCE-2644

Conversation

@Magmusacy

@Magmusacy Magmusacy commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Description

Updated manifest to reflect changes made to fishjam-react-native-webrtc

Motivation and Context

I've made changes to fishjam-react-native-webrtc that makes mediaProjectionService in manifest obsolete

Documentation impact

  • Documentation update required
  • Documentation updated in another PR
  • No documentation update required

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)

@linear

linear Bot commented Jun 15, 2026

Copy link
Copy Markdown

FCE-2644

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Expo config plugin’s Android manifest service configuration to align with changes in fishjam-react-native-webrtc, and cleans up an example screen import to match the project’s React JSX runtime settings.

Changes:

  • Update WebRTCForegroundService manifest entry to include mediaProjection in android:foregroundServiceType when screensharing is enabled, and remove the separate MediaProjectionService manifest entry.
  • Remove the unused default React import from an example tsx screen (the project uses jsx: react-jsx).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
packages/mobile-client/plugin/src/withFishjamAndroid.ts Adjusts generated AndroidManifest service configuration to reflect the updated WebRTC foreground service/screensharing behavior.
examples/mobile-client/fishjam-chat/app/room/[roomName].tsx Removes unused React default import under the automatic JSX runtime.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Magmusacy Magmusacy marked this pull request as ready for review June 15, 2026 12:46
@Magmusacy Magmusacy merged commit ae87f14 into main Jun 18, 2026
2 checks passed
@Magmusacy Magmusacy deleted the merge-fgs/FCE-2644 branch June 18, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants