Update manifest to reflect changes to fishjam-react-native-webrtc#547
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Expo config plugin’s Android manifest service configuration to align with changes in fishjam-react-native-webrtc, and cleans up an example screen import to match the project’s React JSX runtime settings.
Changes:
- Update
WebRTCForegroundServicemanifest entry to includemediaProjectioninandroid:foregroundServiceTypewhen screensharing is enabled, and remove the separateMediaProjectionServicemanifest entry. - Remove the unused default
Reactimport from an exampletsxscreen (the project usesjsx: react-jsx).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/mobile-client/plugin/src/withFishjamAndroid.ts |
Adjusts generated AndroidManifest service configuration to reflect the updated WebRTC foreground service/screensharing behavior. |
examples/mobile-client/fishjam-chat/app/room/[roomName].tsx |
Removes unused React default import under the automatic JSX runtime. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MiloszFilimowski
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated manifest to reflect changes made to fishjam-react-native-webrtc
Motivation and Context
I've made changes to fishjam-react-native-webrtc that makes mediaProjectionService in manifest obsolete
Documentation impact
Types of changes
not work as expected)