Moq nested comparison#266
Merged
Merged
Conversation
# Conflicts: # packages/python-server-sdk
Comparison version addressing review feedback that a dedicated "MoQ" top-nav tab is undesirable. Instead: - rename the main "WebRTC" tab to "Docs" - drop the separate "MoQ" tab and moqSidebar - move MoQ tutorials under Tutorials as a "MoQ Tutorials" category - move "MoQ with Fishjam" into Concepts (explanation) - update internal links and redirects accordingly Applied to both the current docs and the 0.28.0 versioned snapshot. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Per review: explicitly state what MoQ in Fishjam can and cannot do, and that it is a separate delivery path from the WebRTC features (so a separate tab is not implying the two interoperate). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restructures the Media over QUIC (MoQ) documentation by splitting the former combined “livestreaming” tutorial into separate Publishing/Subscribing tutorials for Web and React Native, and renaming the MoQ concept/explanation page to better match the new structure. It also adds redirect rules so older MoQ URLs continue to resolve after the reorg.
Changes:
- Split MoQ tutorials into dedicated Web + React Native Publishing/Subscribing pages (docs + versioned docs).
- Rename/retitle the MoQ explanation page to “MoQ with Fishjam” and update cross-links.
- Add redirects for legacy MoQ paths and minor Docusaurus config refactor.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| versioned_docs/version-0.28.0/tutorials/moq/web-subscribing.mdx | Refactors the v0.28 Web subscribing tutorial and updates links/sections. |
| versioned_docs/version-0.28.0/tutorials/moq/web-publishing.mdx | Adds v0.28 Web publishing tutorial. |
| versioned_docs/version-0.28.0/tutorials/moq/react-native-subscribing.mdx | Adds v0.28 React Native subscribing tutorial. |
| versioned_docs/version-0.28.0/tutorials/moq/react-native-publishing.mdx | Adds v0.28 React Native publishing tutorial. |
| versioned_docs/version-0.28.0/tutorials/moq/category.json | Adds MoQ Tutorials category metadata (v0.28). |
| versioned_docs/version-0.28.0/explanation/moq-with-fishjam.mdx | Renames MoQ explanation page and updates references (v0.28). |
| redirects/index.ts | Adds redirect group for moved/renamed MoQ pages. |
| docusaurus.config.ts | Small refactor around sidebar item generation. |
| docs/tutorials/moq/web-subscribing.mdx | Refactors the current Web subscribing tutorial and updates links/sections. |
| docs/tutorials/moq/web-publishing.mdx | Adds current Web publishing tutorial. |
| docs/tutorials/moq/react-native-subscribing.mdx | Adds current React Native subscribing tutorial. |
| docs/tutorials/moq/react-native-publishing.mdx | Adds current React Native publishing tutorial. |
| docs/tutorials/moq/category.json | Adds MoQ Tutorials category metadata (current docs). |
| docs/explanation/moq-with-fishjam.mdx | Renames MoQ explanation page and updates references (current docs). |
| .claude/settings.json | Adds Claude tool permissions configuration. |
Comments suppressed due to low confidence (2)
docs/tutorials/moq/web-subscribing.mdx:34
- The info box says you need a Fishjam ID to obtain a MoQ token, but the Sandbox token request only needs the Sandbox API URL (the Fishjam ID is needed later to build the relay URL). Reword to avoid implying the ID is required for the token request itself.
versioned_docs/version-0.28.0/tutorials/moq/web-subscribing.mdx:34 - The info box says you need a Fishjam ID to obtain a MoQ token, but the Sandbox token request only needs the Sandbox API URL (the Fishjam ID is needed later to build the relay URL). Reword to avoid implying the ID is required for the token request itself.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
czerwiukk
reviewed
Jun 22, 2026
| "label": "MoQ Tutorials", | ||
| "position": 5, | ||
| "collapsed": false | ||
| } |
Member
There was a problem hiding this comment.
nitpick: i'd add an index page to moq (as in the web&mobile example) and also add the "limitations" note there. right now clicking on "MoQ" only opens the subcategory in the sidebar, this way it would also display the note
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "label": "MoQ Tutorials", | |||
Member
There was a problem hiding this comment.
suggestion:
what do you think about being more explicit? it's a new term
Suggested change
| "label": "MoQ Tutorials", | |
| "label": "Media over QUIC (MoQ)", |
Member
There was a problem hiding this comment.
also - the "tutorials" is redundant since its in "tutorials" category
| sidebar_position: 6 | ||
| title: Media over QUIC (MoQ) | ||
| sidebar_position: 9 | ||
| title: MoQ with Fishjam |
Member
There was a problem hiding this comment.
praise:
Suggested change
| title: MoQ with Fishjam | |
| title: Media over QUIC in Fishjam |
czerwiukk
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes in detail