Skip to content

Bump source-map to 0.8.0 and remove the old type workaround#6202

Open
canova wants to merge 2 commits into
firefox-devtools:mainfrom
canova:source-map-bump
Open

Bump source-map to 0.8.0 and remove the old type workaround#6202
canova wants to merge 2 commits into
firefox-devtools:mainfrom
canova:source-map-bump

Conversation

@canova

@canova canova commented Jul 20, 2026

Copy link
Copy Markdown
Member

Main | Deploy preview

source-map package got recently bumped to 0.8.0 which I was waiting eagerly because previous version had a TypeScript type error for LibSourceMapConsumer.initialize which we had to workaround. Now we can remove that workaround completely.

@canova
canova requested a review from fatadel as a code owner July 20, 2026 12:32
@codecov

codecov Bot commented Jul 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.63%. Comparing base (d4b6ff9) to head (590a4a3).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6202    +/-   ##
========================================
  Coverage   83.63%   83.63%            
========================================
  Files         346      346            
  Lines       37174    37179     +5     
  Branches    10318    10418   +100     
========================================
+ Hits        31090    31095     +5     
  Misses       5656     5656            
  Partials      428      428            

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fatadel fatadel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm checking out this PR and running yarn install creates dirty yarn.lock for me... @canova Could you please check?

@canova
canova force-pushed the source-map-bump branch from 6c74a70 to 590a4a3 Compare July 20, 2026 14:42
@canova

canova commented Jul 20, 2026

Copy link
Copy Markdown
Member Author

Huh weird, I ran both yarn install and npx yarn-deduplicate, but I moved some branches around, maybe that's the reason. Updated.

@canova
canova requested a review from fatadel July 20, 2026 14:48

@fatadel fatadel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants