Upgrade @types/node to match Node 24#6070
Merged
Merged
Conversation
The Node version was bumped to 24 but @types/node was left at v22, so type definitions no longer matched the runtime. Bump it to the latest v24 release. Closes firefox-devtools#5956
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6070 +/- ##
==========================================
- Coverage 83.77% 83.77% -0.01%
==========================================
Files 329 329
Lines 34559 34560 +1
Branches 9574 9576 +2
==========================================
Hits 28952 28952
- Misses 5178 5179 +1
Partials 429 429 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
canova
approved these changes
May 29, 2026
Member
canova
left a comment
canova
left a comment
There was a problem hiding this comment.
LGTM.
I think we can also deduplicate these @types/node@* ones with npx yarn-deduplicate.
Contributor
Author
Oh I didn't know about it, thanks! Done ✅ |
fatadel
added a commit
that referenced
this pull request
Jun 1, 2026
This change was actually part of #6070, but it somehow slipped through. This PR fixes that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Node version was bumped to 24 but @types/node was left at v22, so type definitions no longer matched the runtime. Bump it to the latest v24 release.
Closes #5956