Skip to content

Fix undeclared dependency on typing-extensions#101

Merged
firefly-cpp merged 1 commit intofirefly-cpp:masterfrom
musicinmybrain:typing-extensions
Apr 26, 2026
Merged

Fix undeclared dependency on typing-extensions#101
firefly-cpp merged 1 commit intofirefly-cpp:masterfrom
musicinmybrain:typing-extensions

Conversation

@musicinmybrain
Copy link
Copy Markdown
Contributor

💬 Description

Instead of importing Annotated from typing_extensions, import it from typing; this requires Python 3.9 or later.

This fixes an undeclared runtime dependency on typing-extensions.

Even Python 3.9 is already at end of life, let alone older releases, and you already require Python 3.10+,

python = ">=3.10,<=3.14"

so it should be fine to make this change unconditionally.

❗ Issue Links

Fixes #100

🧪 How Has This Been Tested?

$ python3.13 --version
Python 3.13.13
$ python3.13 -m venv _e
$ . _e/bin/activate
(_e) $ pip install poetry
(_e) $ poetry install
(_e) $ pytest -v
[…]
======================================================================== 71 passed, 86 warnings in 78.52s (0:01:18) =========================================================================

✅ Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas N/A, trivial
  • I have made corresponding changes to the documentation N/A, trivial
  • I have added tests that prove my fix is effective or that my feature works N/A, no obvious way to test for implicit dependencies
  • New and existing unit tests pass locally with my changes

Instead of importing `Annotated` from `typing_extensions`, import it
from `typing`; this requires Python 3.9 or later.

Fixes firefly-cpp#100.
@firefly-cpp
Copy link
Copy Markdown
Owner

Thanks! I will release a new version of this package.

@firefly-cpp firefly-cpp merged commit b84f809 into firefly-cpp:master Apr 26, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

typing_extension not installed but imported

2 participants