Add project router controls to MCP setup#161
Closed
hmishra2250 wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Opened prematurely before local test verification and author review; will be re-proposed after both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The G004 experiment (416 traces, fresh banks) validated the project-local router card in the post-approval
setup mcpstate: +100pp routing lift on Claude and +93.75pp on Codex, safety 0/104 treatment-only regressions per harness (simultaneous upper bound 3.48%, passing the 5% gate with margin), task-success non-inferiority passed. This was the strongest SHIP verdict in the router-card program and the only one without a delivery PR.Summary
firecrawl setup mcp --agent <claude-code|codex> --project <path> --router-cardwrites the managed project router card after MCP setup succeeds.--agent(claude-code/codex only), an explicit--project(safe-path resolved), and authentication;--no-router-cardleaves guidance unchanged;--remove-router-cardremoves only the managed block and conflicts with--router-card.add-mcpnow runs withcwdresolved to--project, so the default (no--global) registration is project-scoped — matching the certified G004 state (project MCP + project card).--globalremains available but is not combined with the card by default.Review question: should
--router-card --globaltogether be rejected? That combination (global registration + project card) is a state G004 did not test; the default path avoids it.Test Plan
src/__tests__/commands/setup-router-options.test.ts— option registration/conflict contracts (48 lines).src/__tests__/commands/setup.test.ts— +170 lines: card written only with auth+agent+project; unsupported agents rejected; remove path bounded; no writes on skills/defaults subcommands.router-card-confidence-closure-20260720.md(sha256 6629e0d1…). Raw results remain in Convex.🤖 Generated with Claude Code