fix(core): allow typing decimals in numeric column filters

[marianmoldovan]

Fixes #715

The bug

You could not type 0.01 into a numeric column filter. The TextField was controlled from the parsed number (String(internalValue)) while onChange ran parseFloat, so every keystroke round-tripped text → number → text and destroyed intermediate states:

typing 0.01:  "0"→0→"0"   "0."→0→"0"   "00"→0→"0"   "01"→1→"1"   RESULT: 1
typing -0.5:  "-"→undef→"" "0"→0→"0"   "0."→0→"0"   "05"→5→"5"   RESULT: 5

parseFloat("0.") and parseFloat("0.0") are both 0, which renders as "0", so 0.01 was unreachable left-to-right. Pasting worked because the text was already canonical. The form/inline editors were unaffected because TextFieldBinding renders value from form state rather than re-deriving it.

The fix

Raw input text lives in its own state and is rendered directly; a syncedValueRef stops the props-sync effect clobbering in-progress typing; parsing is extracted into a pure filter_text_input.ts helper.

typed "0"    -> updateValue=true  value=0
typed "0."   -> updateValue=false value=undefined   ← text preserved, no value written
typed "0.0"  -> updateValue=true  value=0
typed "0.01" -> updateValue=true  value=0.01        ← previously unreachable

is-null still disables the input; the enumValues Select/MultiSelect branches are untouched.

Tests

13 tests on the pure helper, asserting the value after every keystroke for 0.01, 1., -1; final values for 0.001, -0.5, .5, .01, 1.05, 10.00001, -.5; reverse deletion to empty; and that 0 stays a valid filter value.

@firecms/core: 250/253 passing (was 237/240) — 3 pre-existing failures unchanged.

Two judgement calls to review

• The clear (X) button condition moved from internalValue != null to inputText !== "". The earlier 0-shows-the-X fix (c570dd02f) is preserved since "0" is non-empty. Side effect: an emptied string filter no longer shows a dangling X on an empty field.
• Parsing is stricter than parseFloat: "1.2.3", "12abc", "0x10", "1e999" no longer commit bogus values (previously 1.2, 12, 0, Infinity). An improvement, but a behaviour change.

Separate pre-existing quirk found, left alone

Switching the operation away from is-null doesn't work — updateFilter("==", null) re-emits ["==", null] and the sync effect maps it straight back to is-null. Identical on main, unrelated to this issue.

Not verified

Typing behaviour needs a browser. The package's jest testEnvironment is node and the one existing component test already fails to run, so no DOM test was added. Verified instead with a faithful simulation of the new component state machine (both useStates, the ref guard, and the sync effect re-firing after every setValue).

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR fixes numeric column filter typing by decoupling the rendered input text from the parsed filter value, preventing intermediate keystrokes (e.g. 0., -) from being clobbered during controlled re-renders.

Changes:

• Update StringNumberFilterField to render from a dedicated inputText state and parse/commit values only when the text is a “complete” number.
• Add a pure filter_text_input.ts helper to centralize parsing and value→text rendering.
• Add Jest unit tests covering per-keystroke behavior and edge cases for numeric parsing.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
packages/firecms_core/src/components/SelectableTable/filters/StringNumberFilterField.tsx	Switches numeric/string filter input to preserve raw typing while committing parsed values safely.
packages/firecms_core/src/components/SelectableTable/filters/filter_text_input.ts	Introduces strict parsing + value-to-text helper for filter inputs.
packages/firecms_core/src/components/SelectableTable/filters/filter_text_input.test.ts	Adds unit tests validating parsing and per-keystroke commit behavior.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.