Conversation
ctreffs
force-pushed
the
sendable
branch
2 times, most recently
from
August 9, 2026 06:15
1fb6002 to
b939d6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds conditional
Sendableconformance toPoint,Rect, andSizewhen their underlyingValuetype conforms toSendable. This allows instances of these geometric structs to be safely transferred across concurrency domains in Swift 5.5+ without triggering compiler warnings or requiring manual synchronization.Summary of changes:
Sources/FirebladeMath/Point.swift: Addedextension Point: Sendable where Value: Sendable {}Sources/FirebladeMath/Rect.swift: Addedextension Rect: Sendable where Value: Sendable {}Sources/FirebladeMath/Size.swift: Addedextension Size: Sendable where Value: Sendable {}Detailed Design
Syntactically aligns with existing conditional protocol conformances (
Equatable,Hashable,Codable) forPoint,Rect, andSize:Documentation
No external documentation updates are necessary.
Sendableconformance is standard Swift protocol adoption following existing conditional conformances inFirebladeMath.Testing
Verified build and executed unit tests via
swift test. All 258 test cases across 21 test suites passed without issues.Performance
Zero runtime impact.
Sendableconformance is evaluated at compile time by the Swift compiler.Source Impact
Non-breaking additive change. Existing APIs are unchanged, and current user code remains fully compatible.
Checklist