refactor(firestore,android): migrate native implementation to Kotlin - #18616
refactor(firestore,android): migrate native implementation to Kotlin#18616SelaseKay wants to merge 1 commit into
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 馃憤 and 馃憥 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Description
Migrates the
cloud_firestoreAndroid implementation from Java to Kotlin while preserving the existing Pigeon HostApi and EventChannel behavior.FlutterFirebaseFirestorePlugin)javaOuttokotlinOutFlutterFirebaseFirestoreMessageCodecso EventChannels can still emitInternalDocumentSnapshot/ query snapshotsonCancel(query, document, loadBundle, snapshotsInSync), matching the Apple review fix for the same listener leakleft.equal(right), etc.)This PR is not stacked on #18607 (Swift). Both PRs touch
pigeons/messages.dart; rebase whichever lands second.:cloud_firestore:assembleDebugcompiled successfully. The example app was not fully assembled locally (google-services.jsonis not in the tree). Firestore integration tests were not run.Related Issues
None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?