feat(messaging,ios): migrate example iOS runner from ObjC to Swift - #18578
Conversation
Keep the UIScene launch path and notification-center delegate setup so the example matches flutter create and Apple's launch requirements.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Description
Migrates the
firebase_messagingexample iOS runner from the old Objective-C template to Swift, matching whatflutter creategenerates and the UIScene migration guide.The example already used
FlutterSceneDelegateinInfo.plist. This change replacesAppDelegate.h/AppDelegate.m/main.mwithAppDelegate.swiftthat:FlutterImplicitEngineDelegateand registers plugins indidInitializeImplicitFlutterEngineFLTFirebaseMessagingPlugin.configureNotificationCenterDelegate()indidFinishLaunchingWithOptions(Apple requires the notification-center delegate before launch returns)SceneDelegate.swift—Info.plistcontinues to useFlutterSceneDelegatedirectlyAlso adds a Swift snippet next to the existing Objective-C one in the plugin README.
This supersedes #18317 by @champ96k, which started this migration. That PR had unresolved review feedback (UIScene
AppDelegateadoption, no customSceneDelegate, keepFlutterSceneDelegateinInfo.plist) and had drifted frommain(including the laterconfigureNotificationCenterDelegaterequirement). This PR applies those review notes on currentmain.Related Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?