feat(functions): support seedEnv in kit installation and instance configuration - #11012
Merged
Conversation
… helpers ### Description Refactors function kit installation helper APIs (`extractExistingFunctionsInfo`, `promptKitInstanceId`, `promptKitId`, `generateUniqueId`, and `ExistingFunctionsInfo`) to use standard `string[]` arrays instead of `Set<string>` per codebase conventions (using intrinsic arrays in module APIs). ### Scenarios Tested - Unit tests in `src/functions/kits/install.spec.ts` (`npm run mocha:fast -- src/functions/kits/install.spec.ts`). - Verified unique ID generation and suffix collision avoidance with string arrays. - Verified existing kit, codebase, and instance ID validation and prompt collisions. ### Sample Commands N/A (Internal refactoring)
### Description - Adds `skipReport` option to `InstallKitOrInstanceOptions` and `ExistingKitInstallOptions` to allow callers (such as migration tooling) to suppress the first-deploy report. - Supports `seedEnv` in `addKitInstanceOrConfigureProject` when configuring an existing kit instance for an environment/project. - Suppresses `printKitFirstDeployReport` when `skipReport: true` is provided. ### Scenarios Tested - Added unit test in `src/functions/kits/install.spec.ts` verifying `seedEnv` writes `.env.<projectId>` during existing instance configuration. - Added unit test verifying `skipReport: true` suppresses `printKitFirstDeployReport`. - Ran full test suite in `src/functions/kits/install.spec.ts`. ### Sample Commands - `npm test`
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a skipReport option to suppress the first deploy report during function kit installation or configuration. Additionally, it adds support for seeding environment variables for an existing kit instance when seedEnv is provided. Unit tests have been added to verify both features. No review comments were provided, and the implementation is clean and well-tested.
…nto feat_kit_seed_env_skip_report
inlined
changed the title
ajperel
approved these changes
Sep 1, 2026
ajperel
left a comment
ajperel
left a comment
Contributor
There was a problem hiding this comment.
I don't know how to delete my draft comment after you already addressed it and it's outdated. But thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
seedEnvinaddKitInstanceOrConfigureProjectwhen configuring an existing kit instance for an environment/project..env.<projectId>when adding or configuring kit instances programmatically.Scenarios Tested
src/functions/kits/install.spec.tsverifyingseedEnvwrites.env.<projectId>during existing instance configuration.src/functions/kits/install.spec.ts.Sample Commands
npm test