refactor(functions): use string arrays instead of Sets in kit install helpers - #11008
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the tracking of existing kit IDs, codebase names, and instance IDs from Set to string arrays in both the implementation and test files. The review feedback points out that the uniqueness checks using .includes when populating these arrays are redundant because the source data is already validated and guaranteed to be unique, suggesting a simplification to avoid unnecessary lookups.
… helpers ### Description Refactors function kit installation helper APIs (`extractExistingFunctionsInfo`, `promptKitInstanceId`, `promptKitId`, `generateUniqueId`, and `ExistingFunctionsInfo`) to use standard `string[]` arrays instead of `Set<string>` per codebase conventions (using intrinsic arrays in module APIs). ### Scenarios Tested - Unit tests in `src/functions/kits/install.spec.ts` (`npm run mocha:fast -- src/functions/kits/install.spec.ts`). - Verified unique ID generation and suffix collision avoidance with string arrays. - Verified existing kit, codebase, and instance ID validation and prompt collisions. ### Sample Commands N/A (Internal refactoring)
inlined
force-pushed
the
refactor_set_to_array
branch
from
August 31, 2026 22:33
c9046b3 to
cf9170e
Compare
ajperel
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors function kit installation helper APIs (
extractExistingFunctionsInfo,promptKitInstanceId,promptKitId,generateUniqueId, andExistingFunctionsInfo) to use standardstring[]arrays instead ofSet<string>per codebase conventions (using intrinsic arrays in module APIs).Extracted from #11007 to reduce PR size and isolate refactoring.
Scenarios Tested
src/functions/kits/install.spec.ts(npm run mocha:fast -- src/functions/kits/install.spec.ts).Sample Commands
N/A (Internal refactoring)