Add optional maxSizeBytes parameter to uploadObject and use for local builds - #10972
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for custom maximum size limits (maxSizeBytes) when uploading objects to Google Cloud Storage via uploadObject, which is applied to App Hosting deployments during local builds. Unit tests have been added to verify this functionality. Feedback is provided regarding a style guide violation in the test file, where 'as any' was used instead of constructing a proper Response object.
… use for local builds
falahat
force-pushed
the
fix-upload-header-size-limit
branch
from
August 21, 2026 19:20
f9a6fcf to
824b1be
Compare
Yuangwang
approved these changes
Aug 25, 2026
falahat
enabled auto-merge (squash)
August 27, 2026 17:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#10956
Scenarios Tested
Verified the bug with a 249MiB app on main and verified that it worked correctly with this branch
Sample Commands