avoid spreading readdirRecursive results to prevent call stack overflow - #10971
Open
falahat wants to merge 1 commit into
Open
avoid spreading readdirRecursive results to prevent call stack overflow#10971falahat wants to merge 1 commit into
falahat wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the file collection logic in createLocalBuildTarArchive to use a for...of loop instead of spreading mapped array elements, which prevents potential call stack size exceeded errors on large directories. Additionally, a unit test has been added to verify that nested output directories are packaged iteratively. There are no review comments, so I have no further feedback to provide.
…call stack overflow
falahat
force-pushed
the
fix-local-build-callstack-overflow
branch
from
August 21, 2026 19:14
169564c to
19ac7b5
Compare
abhis3
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#10956
The use of lambdas caused a call stack overflow when we had a lot of files
Scenarios Tested
TODO: Need to test with a giant app to reproduce the issue and fix it.
Sample Commands