inject GOOGLE_BUILDABLE from rootDir during local builds - #10970
Open
falahat wants to merge 2 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for a rootDir option in localBuild, which is injected as the GOOGLE_BUILDABLE environment variable to support monorepos or subdirectories during local builds. A corresponding unit test was added to verify this behavior. The review feedback suggests normalizing backslashes to forward slashes in the rootDir path to ensure cross-platform compatibility for Windows environments.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Contributor
Author
|
I need to manually test this with a monorepo local-build app |
falahat
commented
Aug 24, 2026
|
|
||
| const addedEnv = await toProcessEnv(projectId, env); | ||
| if (options?.rootDir) { | ||
| const normalizedRootDir = options.rootDir.replace(/\\/g, "/"); |
Contributor
Author
There was a problem hiding this comment.
Add a comment explaining the windows behavior
Contributor
Author
|
I need to actually confirm if this is 100% required. It doesnt hurt, but online docs suggest this is only relevant for some languages (i.e. golang). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for #10956
Scenarios Tested
TODO: I need to manually test this with a monorepo local-build app
Sample Commands