Handle 403 gracefully when provisioning default compute service account - #10969
Open
falahat wants to merge 3 commits into
Open
Handle 403 gracefully when provisioning default compute service account#10969falahat wants to merge 3 commits into
falahat wants to merge 3 commits into
Conversation
…ute service account
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces changes to gracefully handle 403 Permission Denied errors when provisioning the default compute service account or setting its IAM roles, logging warnings and continuing the deployment instead of throwing an error. The review feedback correctly points out that returning early on a 403 error during service account creation prevents attempting to set IAM roles, which could still succeed if the service account already exists. The reviewer suggests letting the execution fall through to the role assignment step and updating the unit tests accordingly.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
abhis3
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for #10956
If we hit "already exists" or "permission denied" erors when trying to add/update the service account, we continue anyway optimistically with the app deployment.
Scenarios Tested
Sample Commands