feat: extend wire protocol and add requiredRoles to manifest discovery (PR 1)#10732
Open
inlined wants to merge 2 commits into
Open
feat: extend wire protocol and add requiredRoles to manifest discovery (PR 1)#10732inlined wants to merge 2 commits into
inlined wants to merge 2 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for requiredRoles in Cloud Functions deployments by adding the field to the Backend, Build, and WireManifest interfaces, and parsing and validating it during manifest discovery. The reviewer feedback highlights two important improvements: updating the merge utility in backend.ts to prevent requiredRoles from being lost during multi-codebase deployments, and tightening the ROLE_REGEX to enforce stricter GCP naming conventions and catch invalid formats early.
inlined
force-pushed
the
requires-role-1-discovery
branch
from
edc4799 to
e0c76d9
Compare
### Description This is PR 1 in the requiresRole PR chain. It extends the wire protocol to include declared required roles for 2nd generation Cloud Functions, enabling manifest discovery to parse and validate them. ### Scenarios Tested - Run npm test - Run npm run build & npm run lint ### Sample Commands N/A
inlined
force-pushed
the
requires-role-1-discovery
branch
from
e0c76d9 to
771a36b
Compare
wandamora
approved these changes
Jun 29, 2026
Berlioz
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is PR 1 in the requiresRole PR chain.
It extends the wire protocol to include declared required roles for 2nd generation Cloud Functions, enabling manifest discovery to parse and validate them.
Scenarios Tested
Sample Commands
N/A