Fix/issue 1629 auth emulator log spam - #1894
Open
AustinBenoit wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Auth Emulator initialization on Desktop by moving the environment variable checks (USE_AUTH_EMULATOR and AUTH_EMULATOR_PORT) from per-request checks in AuthRequest to a one-time initialization in CreatePlatformAuth, addressing issues with log spam and high CPU utilization. The feedback suggests optimizing the environment variable lookup for AUTH_EMULATOR_PORT to avoid redundant calls to std::getenv and to handle empty port strings safely.
AustinBenoit
marked this pull request as draft
July 29, 2026 19:54
AustinBenoit
force-pushed
the
fix/issue-1629-auth-emulator-log-spam
branch
from
August 6, 2026 15:21
b8e2a10 to
7817a5d
Compare
AustinBenoit
marked this pull request as ready for review
August 6, 2026 15:22
❌ Integration test FAILEDRequested by @AustinBenoit on commit e826162
Add flaky tests to go/fpl-cpp-flake-tracker |
AustinBenoit
force-pushed
the
fix/issue-1629-auth-emulator-log-spam
branch
from
August 6, 2026 16:40
7817a5d to
3574598
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed log spam and high CPU utilization when offline by moving
USE_AUTH_EMULATORenvironment variable check to initialization and eliminating per-request logging (#1629)Testing
Locally test to make sure auth emulator can still be reached. Along with making sure no env variable still talks with prod.
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.Fixes Bugs:
#1629