Skip to content

dataconnect(feat): add "jitter" to exponential backoff logic when reconnecting realtime streaming connections#8456

Open
dconeybe wants to merge 7 commits into
mainfrom
dconeybe/dataconnect/jitter
Open

dataconnect(feat): add "jitter" to exponential backoff logic when reconnecting realtime streaming connections#8456
dconeybe wants to merge 7 commits into
mainfrom
dconeybe/dataconnect/jitter

Conversation

@dconeybe

@dconeybe dconeybe commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

This PR integrates random jitter into the exponential backoff strategy used by firebase-dataconnect when reconnecting query subscriptions. This is achieved by wiring a Random instance from FirebaseDataConnectRegistrar through to DataConnectBidiConnectStream to introduce random jitter between -0.5 and 0.5 to the exponential backoff calculation. This helps reduce thundering herd problems on reconnects.

Highlights

  • Jittered Exponential Backoff: Configured DataConnectBidiConnectStream to use a random jitter factor (varying between -0.5 and 0.5) with RetryBackoffCalculator for reconnecting query subscriptions.
  • Random Source Wiring: Threaded a Random instance from FirebaseDataConnectRegistrar down through FirebaseDataConnectFactory, FirebaseDataConnectImpl, and DataConnectGrpcRPCs to DataConnectBidiConnectStream.
  • Improved Test Coverage: Expanded the subscription retry tests in QuerySubscriptionImplUnitTest to cover zero, minimum, maximum, and varying jitter using property-based tests.
  • Test Code Consolidation: Created RetryBackoffCalculatorTesting to share common backoff test constants and generators, reducing duplication across test files.
Changelog
  • CHANGELOG.md
    • Updated to document the jitter addition under the current release section.
  • DataConnectBidiConnectStream.kt
    • Added a Random parameter to the constructor and initialized RetryBackoffCalculator with a lambda generating jitter between -0.5 and 0.5.
  • DataConnectGrpcRPCs.kt
    • Added random: Random constructor parameter and passed it when instantiating DataConnectBidiConnectStream.
  • FirebaseDataConnectFactory.kt
    • Added random: Random constructor parameter, used it to initialize idStringGenerator, and passed it to FirebaseDataConnectImpl.
  • FirebaseDataConnectImpl.kt
    • Added random: Random constructor parameter and passed it to DataConnectGrpcRPCs.
  • FirebaseDataConnectRegistrar.kt
    • Configured dependency injection to pass Random.Default to FirebaseDataConnectFactory.
  • RetryBackoffCalculator.kt
    • Removed default argument for getRandomJitter constructor parameter to require caller-specified jitter strategy.
  • DataConnectGrpcRPCsUnitTest.kt
    • Updated constructor call to pass Random.Default.
  • FirebaseDataConnectImplUnitTest.kt
    • Updated constructor call to pass Random.Default.
  • QuerySubscriptionImplUnitTest.kt
    • Updated test helper to accept Random and verify that connection retry wait times match expected exponential backoff with zero, min, max, or varying jitter.
  • RetryBackoffCalculatorTesting.kt
    • Created a new test utility object to hold shared constants (backoffValues, minJitterBackoffValues, maxJitterBackoffValues) and an Arb generator for jitter test cases.
  • RetryBackoffCalculatorUnitTest.kt
    • Refactored to use the shared constants in RetryBackoffCalculatorTesting and updated calculator instantiation to provide explicit jitter lambdas.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@dconeybe

Copy link
Copy Markdown
Contributor Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the backoff calculation mechanism in Firebase Data Connect to support customizable random jitter. The RetryBackoffCalculator now requires a jitter generator function, and a Random instance is passed down from the registrar through the factory, implementation, and gRPC classes to the stream. Unit tests have been updated and expanded with a new helper file RetryBackoffCalculatorTesting.kt to verify exponential backoff behavior under various jitter conditions. No review comments were provided, so there is no additional feedback.

@github-actions

Copy link
Copy Markdown
Contributor

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@dconeybe
dconeybe marked this pull request as ready for review July 20, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant