feat(auth): add signInWithCustomToken method#577
Open
dehypnosis wants to merge 1 commit into
Open
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
nilskch
reviewed
Oct 20, 2023
nilskch
left a comment
nilskch
left a comment
There was a problem hiding this comment.
I am not a contributor, but wanted to mention that the return statement is not necessary.
| } | ||
| if _, err = c.httpClient.DoAndUnmarshal(ctx, req, resp); err != nil { | ||
| resp = nil | ||
| return |
There was a problem hiding this comment.
I think the return statement here is not necessary.
vksssd
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Team,
This patch adds a public method to call an API:
Sorry if this PR is not appropriate in contribution process.
Background
Actually, I was using this REST API by calling that with API Key via separated HTTP client as the document described.
But recently, I had to turn Firebase AppCheck for Authentication due to SMS fraud issue. With AppCheck enabled, this API stops to work with "Invalid App Check Token" error in my server. I found no way to embed AppCheck header in internal call. So I forked and added this API call method to firebase admin to make it work with service account credentials. And it resolves the issue.
Please check this issue.
Thanks.