fix(bigquery-firestore-export): remove unused service account plumbing - #2957
Open
IzaakGough wants to merge 1 commit into
Open
fix(bigquery-firestore-export): remove unused service account plumbing#2957IzaakGough wants to merge 1 commit into
IzaakGough wants to merge 1 commit into
Conversation
`serviceAccountName` belongs on the create request, not inside the transfer config, so the value passed here never reached the API. Nothing populated it either, since there is no param for it. The query runs as the function's own account, which is what it would have used regardless. Removing it rather than correcting the placement, because naming an account explicitly needs `actAs` on it, even its own, which would mean requesting project-wide `roles/iam.serviceAccountUser`.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the serviceAccount configuration and parameter from the BigQuery Firestore Export kit. Scheduled queries will now run as the identity that creates them, which is documented in the updated JSDoc for createTransferConfigRequest. Corresponding tests have been updated to reflect this removal. There are no review comments, so I have no feedback to provide.
IzaakGough
marked this pull request as ready for review
August 19, 2026 15:23
CorieW
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createTransferConfigRequestsetserviceAccountNameinsidetransferConfig, but that field belongs onCreateTransferConfigRequest. The proto drops it, so it never reached the API. Nothing populated it in a real deploy either, since there is no param for it.Scheduled queries run as whichever identity created them, which is the kit's own function. That is the same account the dropped field was naming, so behaviour is unchanged.
This removes the config field, the parameter, and the two tests that pinned the misplaced field, and leaves a comment on
createTransferConfigRequestnaming the constraint so the placement is not repeated.Build clean, 19 unit tests pass.