fix(auth): do not show MFA button when the project does not have MFA enabled#1338
fix(auth): do not show MFA button when the project does not have MFA enabled#1338megastep wants to merge 3 commits intofirebase:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces conditional visibility for the MFA management button in SignedInView based on the authentication configuration. Feedback includes a suggestion to mark the internal helper property as private for better encapsulation and a recommendation to add UI or view-level tests to verify the button's presence in the hierarchy, as the current unit tests only validate the underlying logic.
….swift Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@megastep - thank you, this does indeed look like a UI issue that we ought to address. I'll take a look at this a bit more in-depth and provide some feedback 🙏 |
|
Hey @megastep - do you mind merging with main? I tried but it seems that you have protected it. It should resolve CI failures 🙏 |
|
@russellwheatley ok, done! |
This is a simple change to the SignedIn view to conditionally disable showing the manage MFA button when this feature is not enabled in the Firebase project, to prevent user confusion.
Also added a corresponding UI test for this behavior.