fix(auth): improve user identifier retrieval#2314
Merged
demolaf merged 2 commits intoversion-10.0.0-beta03from Apr 9, 2026
Merged
fix(auth): improve user identifier retrieval#2314demolaf merged 2 commits intoversion-10.0.0-beta03from
demolaf merged 2 commits intoversion-10.0.0-beta03from
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a displayIdentifier() extension for FirebaseUser to centralize the logic for retrieving a displayable identifier, ensuring that blank strings are treated as missing values. The reviewer suggests refining this by making the extension support nullable FirebaseUser objects and adding a getDisplayEmail helper to further simplify call sites and remove redundant null-safety checks across the codebase.
app/src/main/java/com/firebaseui/android/demo/HighLevelApiDemoActivity.kt
Show resolved
Hide resolved
app/src/main/java/com/firebaseui/android/demo/HighLevelApiDemoActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/firebaseui/android/demo/HighLevelApiDemoActivity.kt
Outdated
Show resolved
Hide resolved
auth/src/main/java/com/firebase/ui/auth/ui/screens/FirebaseAuthScreen.kt
Show resolved
Hide resolved
auth/src/main/java/com/firebase/ui/auth/ui/screens/FirebaseAuthScreen.kt
Outdated
Show resolved
Hide resolved
auth/src/main/java/com/firebase/ui/auth/ui/screens/FirebaseAuthScreen.kt
Outdated
Show resolved
Hide resolved
russellwheatley
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the empty identifier displayed in the default authenticated UI state composable in
FirebaseAuthScreenfor "Signed in as UID".Closes #2296