refactor: store diff in action object (#1693) - #1701
Open
amnkarn wants to merge 2 commits into
Open
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1693
Description
This PR refactors
getDiffand related consumers to store and access the git diff directly on theactionobject (action.diff). This makes it easier for plugins and subsequent actions (likescanDiff) to retrieve the diff without needing to extract it from thestepcontent.Changes Made
getDiffto assign the diff string directly toaction.diffand updated theActioninterface.scanDiff.tsto retrieve the diff fromaction.diff.PushActionViewintypes.tsto acceptStep | stringfor the diff property.getPushingit-push.tsto handle the new string format.Backward Compatibility
To ensure historical database records and existing UI components do not break, fallback logic has been added. If
action.diffis not present (or is not a string), the system gracefully falls back to extracting the content fromsteps.find((s) => s.stepName === 'diff')?.contentin bothscanDiff.tsandgit-push.ts.