ci: add zizmor scanning and fix workflow issues - #1651
Open
jescalada wants to merge 13 commits into
Open
Conversation
✅ Deploy Preview for endearing-brigadeiros-63f9d0 canceled.
|
Contributor
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1651 +/- ##
=======================================
Coverage 86.06% 86.06%
=======================================
Files 101 101
Lines 5561 5561
Branches 992 992
=======================================
Hits 4786 4786
Misses 526 526
Partials 249 249 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Testing zizmor GH alert removed on ignore
jescalada
marked this pull request as ready for review
July 21, 2026 05:30
Contributor
Author
|
@finos/git-proxy-maintainers Another security hardening PR ready for a look! 🚀 |
3 tasks
Contributor
Author
|
@kriswest Just scanned Zizmor with OSSF Scorecard and it's giving a 6.8 aggregate score. Not sure if this is good enough for us to merge, or if we want to be running scorecard expressly for Zizmor in our CI just in case: 
Issues found
Do you think any of these are worth raising an issue for in zizmor? Or is the maintainer perhaps aware and deliberately excluding them (other than the OSSF badge which he said he want to avoid). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds zizmor scanning to GitProxy and fixes up various issues in workflows. Although some of these are flagged as "high risk", none appear to be directly exploitable. Nevertheless, I figured it'd be great to fix these up to tighten up our workflows.
All 25 issues reported to GitHub Security have been fixed up:
https://github.com/finos/git-proxy/security/code-scanning?query=pr%3A1651+is%3Aclosed
I determined the cache poisoning issues to be false positives since we aren't caching anything in the setup-node steps.
Checklist
General
Documentation