Skip to content

Feature: Updated sidebar icons#18705

Open
yair100 wants to merge 2 commits into
mainfrom
ya/IconsSidebar
Open

Feature: Updated sidebar icons#18705
yair100 wants to merge 2 commits into
mainfrom
ya/IconsSidebar

Conversation

@yair100

@yair100 yair100 commented Jul 9, 2026

Copy link
Copy Markdown
Member

Resolved / Related Issues

To prevent extra work, all changes to the Files codebase must link to an approved issue marked as Ready to build. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.

  • Closes #

Steps used to test these changes

Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.

  1. Tested light, dark, and all high contrast themes.

@yair100 yair100 requested review from 0x5bfa and Josh65-2201 July 9, 2026 15:26
@yair100 yair100 added the ready for review Pull requests that are ready for review label Jul 9, 2026

@Josh65-2201 Josh65-2201 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The home and network icons look oddly small and tags too big.

Also don't like the new style for the home icon, looks old and out of place compared to 4.2.0.0

Image

Josh65-2201
Josh65-2201 previously approved these changes Jul 9, 2026

@Josh65-2201 Josh65-2201 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as Step to test say it should

@yair100

yair100 commented Jul 9, 2026

Copy link
Copy Markdown
Member Author

Fyi @mdtauk

@mdtauk

mdtauk commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

The home and network icons look oddly small and tags too big.

Also don't like the new style for the home icon, looks old and out of place compared to 4.2.0.0

Image

We were using the system provided Home icon previously, now we are using a custom one.

@0x5bfa 0x5bfa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I feel some icons are smaller but these seem to be equal size. Looks like the globe icon is 2px smaller?

Image

@Josh65-2201

Copy link
Copy Markdown
Member

We were using the system provided Home icon previously, now we are using a custom one.

Is there a reason not to use the system one?

@mdtauk

mdtauk commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

We were using the system provided Home icon previously, now we are using a custom one.

Is there a reason not to use the system one?

We could use it, but these icons are all designed as a set, and it also would be inconsistent between Windows 10 and Windows 11 (not a problem for too much longer)

The smaller icons for Networking should use the full space, it may only be 200% dpi or higher where it appears smaller...
image

@mdtauk

mdtauk commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

If it helps, here are some tweaked assets for 32, 40, and 48 sizes.
network_32
network_32-contrast-black
network_32-contrast-white
network_40
network_40-contrast-black
network_40-contrast-white
network_48
network_48-contrast-black
network_48-contrast-white

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review Pull requests that are ready for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants