Experimental: disable derived test.xml spawn (8.7.0-figma)#16
Open
alexeagle wants to merge 2 commits into
Open
Experimental: disable derived test.xml spawn (8.7.0-figma)#16alexeagle wants to merge 2 commits into
alexeagle wants to merge 2 commits into
Conversation
Comment out the generate-xml.sh follow-on spawn on 8.7.0-figma so we can observe checkOutputs behavior when tests do not produce test.xml themselves. Not intended for upstream.
Smaller diff for the experimental disable of generate-xml.sh follow-on spawn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate-xml.shfollow-on spawn inStandaloneTestStrategyfor internal experimentation on 8.7.0-figmacheckOutputsfailure when tests do not produce their owntest.xmlBase
fix_29810-8.7is based on8.7.0-figma(upstream8.7.0+ figma patches). Replaces #15, whose priorfix_29810head tracked upstreammaster(~9.0.0rc1+) and showed a misleading multi-thousand-commit diff.Test plan
sh_test(no native XML) and confirmACTION_OUTPUTS_NOT_CREATEDfor missingtest.xml