Attach an output dataset, reference an input dataset, and accept dict params in create_workunit - #570
Merged
Merged
Conversation
leoschwarz
changed the title
leoschwarz
force-pushed
the
feat/workunit-create-executables
branch
from
August 12, 2026 10:29
77750d5 to
5ce532d
Compare
leoschwarz
changed the title
The eager import tripped the test_lazy_imports guard: importing bfabric.operations.workunit must not pull in polars for callers that create no dataset.
…executables # Conflicts: # bfabric/docs/changelog.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_workunitacceptsdataset(name + base64csv/tsv/parquet), created as the workunit’s output dataset via the existingcreate_dataset.create_workunitacceptsinput_dataset_id, referencing an existing dataset as the workunit’s input (inputdatasetid, previously only ever read).paramsmay now be a plain mapping instead of aCreateWorkunitParams; invalid input raisesValidationErrorbefore any write.failedrather than leaving itavailable.POST /create/workunit/v1gains both new fields, inherited viaCreateWorkunitRequest.executablespart of this branch moved to Attach executables to a workunit in create_workunit #590, stacked on top of this PR.🤖 Prepared with assistance from Claude Opus 5 via Claude Code.