chore(api): align the Express template with the next @seamless-auth/express release#17
Open
Bccorb wants to merge 6 commits into
Open
chore(api): align the Express template with the next @seamless-auth/express release#17Bccorb wants to merge 6 commits into
Bccorb wants to merge 6 commits into
Conversation
@seamless-auth/express 0.8 declares express >= 5.0.0 as a peer dependency, so the template moves off Express 4. @types/express was already on v5.
@seamless-auth/express removes issuer from SeamlessAuthServerOptions, so passing it is now a type error. Remove the issuer line from createSeamlessAuthServer and delete APP_ORIGIN, whose only consumer was that option, from .env.example and the README.
The Express template passed no messaging option, so OTP delivery took the auth API's direct path, which is bypassed in development and never logs the code. Configuring dev-only messaging handlers routes delivery through the adapter so tokens print to the API logs. Gated on NODE_ENV=development.
The React SDK now resolves every call to { data, error } instead of returning the payload or throwing. The login page reads data.providers and data.authorizationUrl, and the callback checks error rather than a .catch the SDK no longer triggers. Depends on @seamless-auth/react 0.5.0; the pin is bumped to ^0.5.0 and this must not merge until that version is published, or template CI install/build will fail.
Express template -> @seamless-auth/express ^0.9.0, react-vite -> @seamless-auth/react ^0.5.0, with lockfiles resolved to the published packages. Removes the local link/vendor scaffolding from the test stack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the Express API template with the upcoming
@seamless-auth/expressrelease. Two commits:Express 5 baseline (existing)
Upgrade the template to Express 5 and
@seamless-auth/express0.8, which requiresexpress >= 5.0.0as a peer dependency. The@types/expresswas already on v5, so runtime and types are aligned.Drop the dead
issueroption@seamless-auth/expressremovesissuerfromSeamlessAuthServerOptions(the silent-refresh service token moved to the fixed M2M contract constants, so the adopter-supplied value reached nothing), and passing it is now a type error. The template no longer setsissuer, andAPP_ORIGIN, whose only consumer was that option, is removed from.env.exampleand the README.Verification
Typechecked the template with its own
tsc -p .against the to-be-released@seamless-auth/expressoption type (withissuerremoved): 0 errors. Confirmed that keepingissueris an excess-property type error against the new type. Template lint clean.Coordination
Merge together with the
remove-dead-issuer-optionchange inseamless-auth-server. The template cannot compile against both the currently publishedexpress@0.8.0(which still requiresissuer) and the next release (which drops it), so the two move as a pair.