fix(verify): build the conformance adapter on Express 5 / Node 24#71
Merged
Conversation
The verify adapter app pinned express@^4, but @seamless-auth/express now declares a peer of express@>=5 (alongside the ecosystem's move to Node 24). Installing the locally-built SDK tarball in --local mode aborted the adapter Docker build with an ERESOLVE peer conflict, canceling the whole compose build and failing every conformance run. Depend on express@^5.1.0 and @seamless-auth/express@^0.8.0, and bump the verify Docker images from node:20 to node:24 to match the ecosystem's supported runtime. server.mjs already uses only Express 5-safe APIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Conformance CI (
conformanceworkflow →seamless verify --local) has been failing on every branch since the ecosystem upgraded to Node 24. The failure is not the Node image version — it's an npm peer-dependency conflict.The verify harness's adapter app (
verify/adapter-app) pinnedexpress@^4.19.2. On the server repo's default branch,@seamless-auth/express@0.8.0now declares:In
--localmode the SDK is built from source and packed into a tarball, then installed over the adapter's deps. Installing@seamless-auth/express(peerexpress@>=5) on top of Express 4 aborts withERESOLVE, which fails theadapterDocker build, cancels the whole compose build, and makesseamless verifyexit 1.From the failing run:
Fix
verify/adapter-app/package.json:express@^4.19.2 → ^5.1.0,@seamless-auth/express@^0.6.0 → ^0.8.0.node:20 → node:24(adapter Dockerfile + the react service's inline Dockerfile) to match the ecosystem's supported runtime (node >=24 <25).server.mjsalready uses only Express 5-safe APIs (named:emailparam, no wildcard routes, no removedapp.del/req.param), so no code changes were needed there.Validation
Reproduced the exact adapter install locally against freshly-packed SDK tarballs from the server repo:
express@^4.19.2): reproduces the CIERESOLVEfailure. ✅ confirmed the root cause.express@^5.1.0): SDK tarballs install cleanly (resolvesexpress@5.2.1), the adapter boots (verify adapter listening), andGET /+ theGET /__captured/:emailroute both respond correctly.Repo test suite: 552 passed. A
patchchangeset is included (theverify/dir ships in the packagefiles).Note: this is independent of and separate from the recently added
seamless login --localmode.