feat: proxy OAuth provider admin routes#112
Merged
Merged
Conversation
Proxy the auth API's new OAuth provider admin routes: GET/POST /system-config/oauth-providers and PATCH/DELETE /system-config/oauth-providers/:id, all gated on the access identity. Register /system-config/oauth-providers in the core cookie requirements table so ensureCookies attaches the access token for both the collection and the id-scoped routes; without it the proxy never populates req.cookiePayload and the routes fail closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proxies the auth API's new OAuth provider admin routes (see fells-code/seamless-auth-api#95):
GET/POST /system-config/oauth-providersPATCH/DELETE /system-config/oauth-providers/:idAll are gated on the access identity via
proxyWithIdentityincreateServer.ts, matching the existing/system-config/*admin routes.@seamless-auth/core: registers/system-config/oauth-providersin theensureCookiescookie-requirements table. The table is matched by prefix, so the single entry covers both the collection and the id-scoped routes. Without it,ensureCookiesnever populatesreq.cookiePayload, so the proxy would not attach the access token and the routes fail closed.Testing
packages/express/tests/oauthProvidersProxy.test.js(5 tests) covering list/create/update/delete forwarding and the unauthenticated case.@seamless-auth/core(83) and@seamless-auth/express(132) suites pass.