fix(build): emit relative paths in published type declarations#102
Merged
Conversation
The declaration build kept the `@/*` tsconfig path aliases in the generated .d.ts files, and nothing rewrote them to relative paths. No consumer can resolve `@/*`, so every downstream project saw the SDK's public surface as `any`, masked by the common `skipLibCheck` default. Add a tsc-alias post-build step (and the `rootDir` it needs) so the emitted declarations use relative imports. Verified the packed tarball's .d.ts is alias-free and the existing 222 tests still pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The declaration build kept the
@/*tsconfig path aliases in the generated.d.ts files, and nothing rewrote them to relative paths. No consumer can resolve
@/*, so every downstream project saw the SDK's public surface asany, maskedby the common
skipLibCheckdefault. Add a tsc-alias post-build step (and therootDirit needs) so the emitted declarations use relative imports. Verifiedthe packed tarball's .d.ts is alias-free and the existing 222 tests still pass.