fix(sessions): label Edge browsers correctly - #196
Open
11suixing11 wants to merge 2 commits into
Open
Conversation
Contributor
|
Taking a look at this! Can you add a credential with edge to see if picks up? |
Author
|
Added this in What changed:
Verification:
|
11suixing11
force-pushed
the
fix/edge-session-browser-label
branch
from
July 29, 2026 07:14
b419bb1 to
0900a5d
Compare
Author
|
Rebased this branch onto the latest Current head: Verification after the rebase:
The build still reports the existing Vite warnings for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Closes #163.
Edge user-agent strings include Chrome and Safari tokens. The previous matching order labeled Chromium Edge sessions as Chrome.
Review Follow-up
@Bccorbasked whether the credential detail surface also picks up Edge correctly. Addressed inb419bb1by adding a UserDetail regression with:src/lib/userAgent.tsThe branch was later rebased onto the latest
mainafter the API types migration; the current head is0900a5d.Verification
npm test -- --run src/pages/Sessions.test.tsx src/pages/UserDetail.test.tsxnpm test -- --runnpm run typechecknpm run lintnpm run format:checknpm run buildgit diff --checkNotes
/config.jsbundling warning and chunk-size warning.