Remove searchResultsToConsider setting and hardcode to 6#2113
Draft
felladrin wants to merge 1 commit into
Draft
Conversation
- Remove the slider from AI settings UI - Remove searchResultsToConsider from defaultSettings - Always wait for search results in canStartResponding() - Hardcode .slice(0, 6) in text generation and chat interface - Update tests and documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the
searchResultsToConsiderslider from AI settings and hardcode the value to 6.Changes
searchResultsToConsiderfromdefaultSettingsinclient/modules/settings.tsAISettingsForm.tsx(including theuseMemofor marks and unused imports)canStartResponding()intextGenerationUtilities.tsto always wait for search results (removed the> 0guard)6intextGeneration.tsandChatInterface.tsxwheresearchResultsToConsiderwas used for slicing resultssettings.test.tsconfiguration.md,ai-integration.md,overview.mdRationale
The default value of 3 was too few for good LLM responses. Hardcoding to 6 gives the model more context without requiring user configuration. The slider was a false choice — most users left it at 3, which produced suboptimal results.