Security: Missing ownership filter updates all users' followed tags#429
Open
tomaioo wants to merge 1 commit intofedify-dev:mainfrom
Open
Security: Missing ownership filter updates all users' followed tags#429tomaioo wants to merge 1 commit intofedify-dev:mainfrom
tomaioo wants to merge 1 commit intofedify-dev:mainfrom
Conversation
The follow/unfollow handlers update `accountOwners.followedTags` without a `WHERE` clause tied to the authenticated owner. As written, a single authenticated request modifies followed tags for every account owner in the database, causing cross-account data tampering. Signed-off-by: tomaioo <203048277+tomaioo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security: Missing ownership filter updates all users' followed tags
Problem
Severity:
High| File:src/api/v1/tags.ts:L28The follow/unfollow handlers update
accountOwners.followedTagswithout aWHEREclause tied to the authenticated owner. As written, a single authenticated request modifies followed tags for every account owner in the database, causing cross-account data tampering.Solution
Restrict updates to the authenticated account owner, e.g.
.where(eq(accountOwners.id, owner.id)). Also consider de-duplication and idempotency checks when appending tags.Changes
src/api/v1/tags.ts(modified)