Run format before format:check in init hydration test validation - #952
Conversation
✅ Deploy Preview for fedify-json-schema canceled.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the validateDevToolScripts function in packages/init/src/test/create.ts to include the "format" script in the validation loop alongside "format:check" and "lint". There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughHydration test validation now runs ChangesDeveloper-tool validation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/init/src/test/create.ts`:
- Line 158: Update the shared validation loop to include only format:check and
lint, removing format from the scripts iterated there. Preserve the existing
Astro-specific format execution so Astro projects run format once, while other
frameworks are not required to define a format script.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 743a417a-8773-43b8-9f92-3fdd8fe34851
📒 Files selected for processing (1)
packages/init/src/test/create.ts
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
918033f to
7cd7f85
Compare
|
Great! Before merging this PR, please rebase from the main branch. |
`validateDevToolScripts` only ran `format:check` and `lint` after scaffolding a project, without auto-formatting it first. Since neither Fedify's own generated files nor most scaffolding CLI output exactly match the project's chosen formatter's style, `format:check` almost always failed for `npm`/`pnpm` package managers, causing the entire hydration test suite to fail regardless of the actual generated code. fedify-dev#950 Assisted-by: Claude Code:claude-sonnet-5
`validateDevToolScripts` special-cased Astro to run `format` before `format:check`/`lint`, added in 5f10801 while fixing Astro 5-7 compatibility. Since the previous commit now runs `format` for every framework before `format:check`, this block just ran `format` a second time for Astro with no effect, so it's dead code now — removed it. fedify-dev#950 Assisted-by: Claude Code:claude-sonnet-5
`validateDevToolScripts()` returned `false` when a script failed, which kept the directory out of the later lookup test even when the scaffolded app itself worked fine. These scripts aren't essential to whether the app runs, so print a warning instead of returning `false`, letting the lookup test proceed regardless. fedify-dev#950 Assisted-by: Claude Code:claude-sonnet-5
28d1d68 to
4ca0eab
Compare
3 participants
Summary
Current
validateDevToolScriptsonly runsformat:checkandlintafter scaffolding a project, without auto-formatting it first. Since neither Fedify's own generated files nor most scaffolding CLI output exactly match the project's chosen formatter's style,format:checkalmost always failed fornpm/pnpmpackage managers, causing the entire hydration test suite to fail regardless of the actual generated code. Fixed by runningformatscript beforeformat:checkso that scaffolded projects are already compliant with the formatter before being checked.Assisted-by: Claude Code:claude-sonnet-5
Related issue
formatbeforeformat:checkinfedify init's hydration test validation #950Changes
formatscript beforeformat:checkinvalidateDevToolScriptsfunction.Benefits
npm/pnpmwill not fail because of format issue.Checklist
Did you write some relevant docs about this change (if it's a new feature)?Did you write some tests for this change (if it's a new feature)?mise teston your machine?