build: fix SagePatch requirement failure on non-SDL3 builds#198
Draft
fbraz3 wants to merge 2 commits into
Draft
Conversation
Fixes #190 SagePatch requires SDL3. When building cross-platform variants that don't use SDL3 by default (such as mingw cross-builds), the SagePatch option was defaulting to ON, causing a CMake fatal error during configuration. This dynamically inherits the default for RTS_BUILD_OPTION_SAGE_PATCH from SAGE_USE_SDL3, similar to how SAGE_UPDATE_CHECK is handled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #190
Changes
RTS_BUILD_OPTION_SAGE_PATCHinherit its default value fromSAGE_USE_SDL3dynamically inconfig-build.cmake, avoiding errors in cross-builds like MinGW which have SDL3 disabled by default.